Remove Redis TOI dump command #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this removes functionality, it'll need a VERSION bump. |
rmarianski
approved these changes
May 2, 2017
|
I don't think this PR removes functionality or warrants a major version bump. This removes a temporary helper command to migrate us away from a Redis-based TOI and towards S3 or file-based TOI. The existing load- and dump- tiles of interest commands still exist. I suppose removing support for Redis TOI in general could warrant a major rev. |
|
@iandees We've done our prod migration, can this PR be merged now? |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we migrate the tiles of interest set from Redis in #193, we should merge this PR so that the command that dumps from Redis is removed.