Makes queries per-table #227
Conversation
rmarianski
force-pushed
the
query-by-table
branch
from
192085a
to
7330cae
Compare
rmarianski
force-pushed
the
query-by-table
branch
from
7330cae
to
91dfa8c
Compare
|
|
||
|
|
||
| def convert_source_data_to_feature_layers(rows, layer_data, bounds, zoom): | ||
| # TODO we might want to fold in the other processing into this |
There was a problem hiding this comment.
Is this a note for the glorious future or for the current sprint?
There was a problem hiding this comment.
This would have been a performance improvement, if we find that when we run it on dev it's too slow. If it's unnecessary, it might be better to hold off on this since it might change with phase 3 anyway.
| for layer_datum in layer_data: | ||
| layer = layer_datum['name'] | ||
| features = features_by_layer[layer] | ||
| # TODO padded bounds |
There was a problem hiding this comment.
To support the MVT Buffered format or something additional?
tilequeue/process.py
Outdated
| boundaries_geometry = row.pop('__boundaries_geometry__', None) | ||
| assert geometry or boundaries_geometry | ||
|
|
||
| common_props = row.pop('__properties__', None) or {} |
There was a problem hiding this comment.
Is this the same thing as row.pop('__properties__', {})?
There was a problem hiding this comment.
Oh, I see... the way it is at the moment handles the case where row['__properties__'] exists, but is None. I feel like that's slightly non-obvious.
There was a problem hiding this comment.
I just confused myself too, so I expanded it out and added a comment in da19aa0.
Connects to https://github.com/mapzen/tile-tasks/issues/267
Links up with tilezen/tileserver#110 and tilezen/vector-datasource#1352.