Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct function used for parser #237

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Correct function used for parser #237

merged 1 commit into from
Aug 8, 2017

Conversation

rmarianski
Copy link
Member

Previously, the command fn bound for a parser would always be the last
one. This creates a new function instead of each binding to the same
one.

Previously, the command fn bound for a parser would always be the last
one. This creates a new function instead of each binding to the same
one.
Copy link
Member

@zerebubuth zerebubuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops! So it only worked for me because the command/function I was using was the last one, which I just added? D'oh!

@rmarianski
Copy link
Member Author

Ooops! So it only worked for me because the command/function I was using was the last one, which I just added? D'oh!

Bad luck :) I didn't catch it in the review either, just noticed it now when I happened to try and run a different command.

@rmarianski rmarianski merged commit 76f8805 into master Aug 8, 2017
@rmarianski rmarianski deleted the command-parser-fn branch August 8, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants