Fix fixture source property #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2017 10:22
This was removed in 1326573 and back-filled using the table's source 'meta' property for the RAWR data fetcher, but was omitted from the fixture data fetcher.
…he fixture data fetcher.
rmarianski
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current integration test failures over in
vector-datasourceare because I dropped thesourcetag in commit 1326573 because in practice we override it with our own definition of the source of the data.However, I forgot to add the tag back in for the fixtures, meaning that a whole chunk of logic which depends on the source was failing.
This adds the tag back in for fixtures, and adds a unit test to make sure that it stays there.