Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add road sort key tests #74

Merged
merged 4 commits into from
Mar 2, 2016
Merged

Add road sort key tests #74

merged 4 commits into from
Mar 2, 2016

Conversation

rmarianski
Copy link
Member

Connects to tilezen/vector-datasource#546

@nvkelso could you review please?

@rmarianski
Copy link
Member Author

I pointed to a different tilestache branch in circleci temporarily. I'll remove that before merging the pr.

@nvkelso
Copy link
Member

nvkelso commented Feb 29, 2016

Should these tests stay in this repo / special hard coded branch?

How do we run them (is that stated in a README somewhere)?

@nvkelso
Copy link
Member

nvkelso commented Feb 29, 2016

Otherwise looks good.

@rmarianski
Copy link
Member Author

I'd rather have the tests stay where they are, and pull the transform and sort functions out of the tilestache branch and into tilequeue. Or, we might want to just move them all to vector-datasource, make that into a python package, and have these tests run from there. Imho, in the longer run it makes more sense to have them in vector-datasource because they'll be in the same repo as the queries and sql functions, and they tend to change in concert.

Btw, I'll kill the custom branch from the circle config before merging. That's just a shim to get this pr to run the tests against the appropriate tilestache branch in the interim.

And tilequeue tests are run in the usual python way, python setup.py test. That's what circle currently does. The tilequeue repo itself doesn't have any docs, but this repo itself is very Mapzen specific about how we process tiles offline, and geared towards our architecture. There are some more generally useful bits in there, which we could extract into its own python tile library, but we ourselves don't have much to gain from doing that at the moment.

@nvkelso
Copy link
Member

nvkelso commented Feb 29, 2016

Sounds good with me.

Longer term I agree with moving more of this stuff (transforms, tests) into vector-datasource directly. But that's separate that this current work.

@rmarianski rmarianski force-pushed the add-road-sort-key-tests branch from a288149 to 3c213b6 Compare March 2, 2016 19:14
rmarianski added a commit that referenced this pull request Mar 2, 2016
@rmarianski rmarianski merged commit f5ef172 into master Mar 2, 2016
@rmarianski rmarianski deleted the add-road-sort-key-tests branch March 2, 2016 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants