-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add road sort key tests #74
Conversation
I pointed to a different tilestache branch in circleci temporarily. I'll remove that before merging the pr. |
Should these tests stay in this repo / special hard coded branch? How do we run them (is that stated in a README somewhere)? |
Otherwise looks good. |
I'd rather have the tests stay where they are, and pull the transform and sort functions out of the tilestache branch and into tilequeue. Or, we might want to just move them all to vector-datasource, make that into a python package, and have these tests run from there. Imho, in the longer run it makes more sense to have them in vector-datasource because they'll be in the same repo as the queries and sql functions, and they tend to change in concert. Btw, I'll kill the custom branch from the circle config before merging. That's just a shim to get this pr to run the tests against the appropriate tilestache branch in the interim. And tilequeue tests are run in the usual python way, |
Sounds good with me. Longer term I agree with moving more of this stuff (transforms, tests) into |
a288149
to
3c213b6
Compare
Connects to tilezen/vector-datasource#546
@nvkelso could you review please?