Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review sort_key spreadsheets #1012

Closed
rmarianski opened this issue Aug 30, 2016 · 2 comments
Closed

Review sort_key spreadsheets #1012

rmarianski opened this issue Aug 30, 2016 · 2 comments
Assignees
@nvkelso
Labels
qa needed
Milestone
v1.0.0

Comments

@rmarianski
Copy link
Member

rmarianski commented Aug 30, 2016 •
edited by nvkelso
Loading

We've normalized some kind and kind_detail values. We should review the sort_key spreadsheets to ensure that they match on the new values.

In particular, the boundaries spreadsheet needs updating.
@rmarianski rmarianski added this to the v1.0.0 milestone Aug 30, 2016
@nvkelso nvkelso self-assigned this Aug 31, 2016
@nvkelso nvkelso added the ready label Aug 31, 2016
@nvkelso
Copy link
Member

nvkelso commented Aug 31, 2016

Other layers look fine (Matt already updated roads), it's just boundaries that needs work.

@nvkelso nvkelso mentioned this issue Aug 31, 2016
Closed
nvkelso added a commit that referenced this issue Aug 31, 2016
@nvkelso
connects to #1012 for boundary sort_key updates and tests
b67ae19
@nvkelso nvkelso added in review and removed ready labels Aug 31, 2016
nvkelso added a commit that referenced this issue Aug 31, 2016
@nvkelso
Merge pull request #1017 from tilezen/nvkelso/1012-review-sort_key-sp…
0c35522 
…readsheets

connects to #1012 for boundary sort_key updates and tests
@nvkelso nvkelso mentioned this issue Sep 2, 2016
Merged
3 tasks
@nvkelso
Copy link
Member

nvkelso commented Sep 9, 2016

This is working.

@nvkelso nvkelso closed this as completed Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvkelso nvkelso

Labels
qa needed
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@rmarianski @nvkelso