Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kind_detail for aerodrome #1277

Closed
nvkelso opened this issue Jun 21, 2017 · 4 comments
Closed

Add kind_detail for aerodrome #1277

nvkelso opened this issue Jun 21, 2017 · 4 comments
Assignees
@zerebubuth
Labels
enhancement layer-landuse layer-pois
Milestone
v1.8.0

Comments

@nvkelso
Copy link
Member

nvkelso commented Jun 21, 2017

Looks like there's disambiguation between types of airports:

Common values include:

We probably shouldn't include all these...

  • public
  • private
  • military
  • military/public
  • civil
  • gliding
  • club
  • heliport
  • glider
  • regional
  • airstrip
  • international
  • abandoned
  • altiport
  • private/public
  • military/private
@nvkelso nvkelso mentioned this issue Nov 2, 2017
Closed
47 tasks
@nvkelso nvkelso mentioned this issue Feb 20, 2019
Closed
@nvkelso nvkelso added this to the v1.8.0 milestone Feb 20, 2019
@zerebubuth zerebubuth mentioned this issue Mar 13, 2019
Merged
@ghost ghost assigned zerebubuth Mar 13, 2019
@ghost ghost added the in review label Mar 13, 2019
@nvkelso nvkelso mentioned this issue Mar 13, 2019
Closed
@nvkelso
Copy link
Member Author

nvkelso commented Mar 13, 2019

Passing the kind_detail onto runway lines is covered in #1852.

zerebubuth added a commit that referenced this issue Mar 15, 2019
@zerebubuth
Assign aerodrome kind_detail to runways.
4a1f5c5 
Aerodrome polygons are (usually) used to map the footprint of an airport, and often have an `aerodrome:type` tag to indicate whether it's an international or domestic airport. We added that as `kind_detail` in #1277, but it's useful to know that information on runways also. This allows us to hide runways of smaller airports and emphasise those of bigger (international) ones.

This extends the intercut / overlap methods to add "where" clauses, so that we can select those features within the layer which are being cut or used for cutting. We can then overlap the aerodrome polygons with the runways (lines in `roads` layer, polygons in `landuse`) to assign the `kind_detail`.

Worth noting; we already had a `kind_detail` on the runway lines in the `roads` layer, so I've called this new attribute `aerodrome_kind_detail` instead.
@zerebubuth zerebubuth mentioned this issue Mar 15, 2019
Merged
@nvkelso
Copy link
Member Author

nvkelso commented Mar 27, 2019

We still need to pass this to the POI.

@zerebubuth
Copy link
Member

We still need to pass this to the POI.

Since we generate the POI label point and polygon from the same feature, and the rules for kind_detail look to be the same, I think this information will already be on the POI. We should check once we have the first proper v1.8 build to make sure, in case of bugs 🪲

@nvkelso nvkelso mentioned this issue Apr 22, 2019
Closed
@nvkelso
Copy link
Member Author

nvkelso commented Apr 22, 2019

Sadly not very many airports have this tagged, but it is working as designed per this PR.

We should probably backfill this for international based on the presence of 3-char IATA codes, too. But for another issue in #1873 as the basic request here is working.

It is on the landuse:

image

It is passing to the POI:

image

I expect the runway lines to also have a aerodrome_kind_detail property via #1854:

image

@nvkelso nvkelso closed this as completed Apr 22, 2019
@ghost ghost removed the in review label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
enhancement layer-landuse layer-pois
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@zerebubuth @nvkelso