Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpine huts should show up earlier #1407

Closed
matkoniecz opened this issue Oct 17, 2017 · 2 comments
Closed

alpine huts should show up earlier #1407

matkoniecz opened this issue Oct 17, 2017 · 2 comments
Assignees
Milestone

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 17, 2017

tl;dr

alpine_hut poi min_zoom 13 from 15.

===

  • What did you see?

http://www.openstreetmap.org/relation/5162163#map=19/49.54372/20.11861 at https://mapzen.com/tangram/play/?#18.25000/49.54396/20.11811 has no indicator that it is a alpine hut or named building

  • What did you expect to see?

alpine hut data, or at least names of buildings for alpine huts mapped as polygons together with building (this is a correct tagging)

  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.
  • Screenshot? Props for animated gifs.

See above

default OSM style is displaying tourism=alpine_hut from z13 (very early)

selection_001

http://wiki.openstreetmap.org/wiki/Tag:tourism%3Dalpine_hut https://taginfo.openstreetmap.org/tags/tourism=alpine_hut#map is a widely used tag indicating a very important object, rarely existing so data overhead is minimal

https://github.com/tilezen/vector-datasource/search?utf8=%E2%9C%93&q=alpine_hut&type= seems to be querried, so maybe failure is caused by alpine huts mapped as polygons, but https://mapzen.com/tangram/play/?#19.00000/49.60417/18.82297 with http://www.openstreetmap.org/node/718705156#map=17/49.60385/18.82659 mapped as node also failed to appear on my attempt to display alpine_hut nodes

@matkoniecz matkoniecz changed the title alpine huts mapped as polygons are missing alpine huts (maybe only ones mapped as polygons) are missing Oct 17, 2017
@nvkelso
Copy link
Member

nvkelso commented Oct 18, 2017

I think this is "works as expected" now, but with some existing issues you are probably interested in.

How it works now...

The alpine_hut tag is stripped off the building and included in the pois layer as a point label.

screen shot 2017-10-18 at 12 54 55

That leaves the building polygon not know what kind of building it is, because it's only tagged building=yes.

screen shot 2017-10-18 at 12 55 17

screen shot 2017-10-18 at 12 57 37

We could guess / make it consistent with the pois logic. That's proposed for the next release under: #487

The remaining piece from this issue is proposing to move alpine_hut pois to zoom 13 from zoom 15. I agree they should show up earlier so keeping this issue open and changing title.

@nvkelso nvkelso changed the title alpine huts (maybe only ones mapped as polygons) are missing alpine huts should show up earlier Oct 18, 2017
@nvkelso nvkelso added this to the v1.6.0 milestone Oct 18, 2017
@nvkelso nvkelso modified the milestones: v1.6.0, v1.5.0 Nov 13, 2017
@nvkelso nvkelso self-assigned this Dec 21, 2017
@nvkelso
Copy link
Member

nvkelso commented Jul 5, 2018

Both the pois min_zoom and the buildings kind_detail via #487 are verified on dev.

@nvkelso nvkelso closed this as completed Jul 5, 2018
@ghost ghost removed the send to staging label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants