More predictable layers for landuse label positions (more pois)

[nvkelso]

We currently have a random mix of poi like features in the landuse and the pois layer. We should make this more predictable.

Generally if it is worth having an icon for it, it should be in the pois layer. Things with name only (like building names in the building layer) should stay in the landuse layer.

The landuse polygon should always be in the landuse layer. But this is additionally complicated since a few of these should probably move to the earth layer (like grass, meadow, land, glacier, etc; see also the road landuse_kind intercut problems), and some potentially to a new infrastructure layer (eg apron, footway, pedestrian). And sometimes a natural area is also a protected area, in which case it should stay in the landuse layer.

~50 landuse features have a label position in the landuse layer only.

Some / most of these need filters added in the POIs YAML config file.

• allotments - move to earth layer?
• apron - move to earth layer?
• breakwater - move to earth layer?
• bridge - candidate for pois layer filter
• cemetery - candidate for pois layer filter
• commercial - move to earth layer?
• common - move to earth layer?
• cutline - move to earth layer?
• dike - move to earth layer?
• farm - candidate for pois layer filter
• farmland - move to earth layer?
• farmyard - move to infrastructure layer?
• footway - move to infrastructure layer?
• forest - candidate for pois layer filter
• fuel - candidate for pois layer filter
• garden - candidate for pois layer filter
• glacier - candidate for pois layer filter
• golf_course - candidate for pois layer filter
• grass - move to earth layer?
• groyne - move to earth layer?
• industrial - move to earth layer?
• land - move to earth layer?
• meadow - move to earth layer?
• military - candidate for pois layer filter
• national_park - candidate for pois layer filter
• nature_reserve - candidate for pois layer filter
• park - candidate for pois layer filter
• park or protected land - this was is an old Natural Earth value that should probably just be park
• pedestrian - move to infrastructure layer?
• pier - move to infrastructure layer?
• pitch - candidate for pois layer filter
• plant - candidate for pois layer filter
• protected_area - candidate for pois layer filter
• quarry - candidate for pois layer filter
• railway - move to infrastructure layer?
• recreation_ground - candidate for pois layer filter
• residential - move to earth layer?
• retail - candidate for pois layer filter
• runway - move to infrastructure layer?
• rural - move to earth layer?
• scree - move to earth layer?
• scrub - move to earth layer?
• substation - candidate for pois layer filter
• taxiway - move to infrastructure layer?
• urban - move to earth layer?
• urban area - this was is an old Natural Earth value that should probably just be urban
• village_green - candidate for pois layer filter
• wastewater_plant - candidate for pois layer filter
• water_works - candidate for pois layer filter
• wetland - move to earth layer?
• winter_sports - candidate for pois layer filter
• wood - move to earth layer?
• works - candidate for pois layer filter

~40 landuse features already end up with a label position in the pois layer:

There are already "working", modulo discussion above about which layer their polygon should end up in.

• aerodrome
• amusement_ride
• animal
• aquarium
• artwork
• attraction
• aviary
• beach - should this end up in earth layer, but still have pois label?
• carousel
• cinema
• college
• enclosure
• generator
• hanami
• hospital
• library
• maze
• parking - should this end up in earth layer, but still have pois label?
• petting_zoo
• place_of_worship
• playground
• prison
• resort
• roller_coaster
• school
• shelter
• sports_centre
• stadium
• summer_toboggan
• theatre
• theme_park
• toilets
• trail_riding_station
• university
• water_slide
• wilderness_hut
• wildlife_park
• winery
• zoo

[nvkelso]

Is this a dup of #679, but with more details about how to resolve it?

[nvkelso]

Examples in SF's Golden Gate Park:

• Correctly kind: garden: https://www.openstreetmap.org/way/120480366
• Incorrectly kind:attraction, expected kind:garden: https://www.openstreetmap.org/way/120480164

Combo order of operations (garden needs to be before attraction) and that garden is only in landuse, but POIs are harvested before landuse, and garden isn't in POIs list.

/cc @sensescape

[nvkelso]

Updated list of things to make POIs, all should be throttled by area?:

kind @ min_zoom

• cemetery @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
  • also add amenity=grave_yard to pois and landuse layers as kind:grave_yard with the similar ranges as cemetery. min_zoom: GREATEST( LEAST(zoom - 3, 17), 13)
• farm @ 15
• forest @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 12)
• golf_course @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 12)
• military @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 9)
• national_park @ try: min_zoom: (zoom - 2), ideally big ones at very low zooms
• nature_reserve @ try: min_zoom: (zoom - 2), ideally big ones at very low zooms
• park @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 12)
• plant @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• pitch @ 16
• protected_area @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 7)
• quarry @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• recreation_ground @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• substation @ 15
• village_green @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• wastewater_plant @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• water_works @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)
• winter_sports @ try: min_zoom: GREATEST( LEAST(zoom - 1, 13), 10)
• wood @ try: min_zoom: GREATEST( LEAST(zoom - 2, 14), 12)
• works @ try: min_zoom: GREATEST( LEAST(zoom - 3, 14), 12)

See also, but unrelated (for the ones that remain in landuse but have labels generated):

• Add support for configurable pixel sizes #851

[nvkelso]

Working well for me!