Update NE road properties #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_no_matching_feature( | ||
| 7, 63, 42, 'roads', | ||
| { 'source': 'naturalearthdata.com', 'kind': 'highway', | ||
| 'namealtt': None }) |
There was a problem hiding this comment.
Should these tests be for None or type(None)?
There was a problem hiding this comment.
These are negative matches (assert_no_matching_feature), so the tests could be translated as "assert that there are no NE highways with any level", and so forth. The aim is to make sure that all of the level, namealt and namealtt properties have been removed.
There was a problem hiding this comment.
Ah ok, sorry I didn't catch that when reading through it initially. 👍
|
👍 (modulo Rob's comment above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #896.
@nvkelso could you review, please?