Clip buildings to tiles. #1446
Merged
Clip buildings to tiles. #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2017 17:51
|
This is not obvious, but if you follow all the issue references, we're hoping the building clip solves the landuse_kind intercut problems in #1226. Can you add tests in this PR to prove that's true, please? |
|
This won't solve all the Just to be clear: We'll get different kinds of problems instead when buildings cross tile boundaries and one half gets assigned a different
|
|
Well, sorry to be the bearer of bad news but now #1226 is assigned to you, too ;) Thanks for the illustration. I agree it's a related but different issue than this one. |
rmarianski
approved these changes
Dec 1, 2017
added 3 commits
December 5, 2017 16:03
This checks that buildings which cross tile boundaries are more likely to be assigned the correct landuse kind. The issue was that, before the change from query-per-layer to query-per-table, we were clipping the landuse to the tile but the building to a 3x3 tile area. This meant that large buildings had much less overlap with landuse polygons, and some would not be assigned a `landuse_kind`. Now we clip all inputs (except water) to the tile, which solves this problem, but means that the same building in adjacent tiles could be assigned different `landuse_kind`s. Additionally, it looks like `kind: building_part`s weren't being assigned a `landuse_kind`, although the test now passes, so something we changed has fixed that too.
|
@nvkelso how do those new tests look? |
|
@nvkelso all good to merge? |
|
Yes. |
nvkelso
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was done already as part of #1352, so this PR just updates the test to have the behaviour that we want; that all building geometry is within the tile bounds.
Fixes #1142.