Include all name variants. #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behaviour was to de-duplicate name variants with the same value as the main name tag. However, that breaks name fall-back logic when one doesn't want to fall back to the main name. For example, something tagged with `name=Foo, name:A=Foo, name:B=Bar` would remove the `name:A` tag, meaning that if the name preference display was `A` then `B` then local, it would display `Bar` instead of `Foo`.
iandees
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour was to de-duplicate name variants with the same value as the main name tag. However, that breaks name fall-back logic when one doesn't want to fall back to the main name. For example, something tagged with
name=Foo, name:A=Foo, name:B=Barwould remove thename:Atag, meaning that if the name preference display wasAthenBthen local, it would displayBarinstead ofFoo.Connects to #1406.