Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graveyard religion information to kind_detail #1457

Merged
merged 6 commits into from
Feb 5, 2018
Merged

Add graveyard religion information to kind_detail #1457

merged 6 commits into from
Feb 5, 2018

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Dec 15, 2017

Relates to #1425

nvkelso
nvkelso previously requested changes Dec 21, 2017
View reviewed changes
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to also be made for cemetery in Landuse and for both graveyard and cemetery in the POIs YAML.

kind_detail: { col: religion }
denomination: { col: denomination }

@pnorman
Copy link
Collaborator Author

pnorman commented Dec 23, 2017

Rebased and changes made.

nvkelso
nvkelso approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nvkelso nvkelso merged commit b3d1dcb into tilezen:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkelso nvkelso nvkelso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnorman @nvkelso