Slimming down boundaries #1725
Merged
Slimming down boundaries #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `id:left` and `id:right` properties at mid and low zooms (z<13) which are almost-unique and prevent effective merging.
nvkelso
reviewed
Dec 11, 2018
docs/layers.md
Outdated
| @@ -151,8 +149,10 @@ Combination of OpenStreetMap administrative boundaries (zoom >= 8) and Natural E | |||
|
|
|||
| #### Boundaries properties (common optional): | |||
|
|
|||
| * `id:left`: For the relation on the left side of the boundary line. | |||
| * `id:right`: For the relation on the right side of the boundary line. | |||
| * `name`: A suggested label, formed from the left and right region names, if available. If the name appears to be too long to be rendered on the geometry at a particular zoom it may be omitted. | |||
There was a problem hiding this comment.
The name and id are still common properties, we just strip them at low zooms. I like the new description text, but please move them back to the common section. (This will better match roads and other layer documentation.)
There was a problem hiding this comment.
OK, cool. Fixed in 4a01b1d.
This was referenced Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
id:leftandid:rightproperties at mid and low zooms (z<13) which are almost-unique and prevent effective merging. Pushmin_zoomforlocalityboundaries from 10 to 11.On a test tile,
9/285/169, which is a pretty extreme example, we get a layer size reduction of 70% (from 78kB down to 23kB) from theid:leftandid:rightdrop, and a further 83% reduction (from 23kB down to 4kB) by not includinglocalityat this zoom level. Overall, the layer is 91% smaller!Connects to #1715.