Use a Jinja filter to provide repr in test templates. #1744
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, was just quoting everything as a unicode string, which was good enough in 99% of cases. However, sometimes it's nice to be able to round-trip values from the command line
--expect, which takes a JSON-encodeddict, and the test. For example, not having it quotemin_zoomas a string when I specified it as a number.As a bonus, I also de-unicode strings where they can be specified as plain
str, which is the case for all the keys and most of the values that we have in our tests, and makes the output slightly more readable.