Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap landuse kinds at mid and low zooms. #1790

Merged
merged 3 commits into from
Jan 17, 2019

Conversation

zerebubuth
Copy link
Member

Remap kind of various landuse layer features to give better opportunity for mid and low zoom merging.

Many of the kinds specified in #1779 depend on #1781, and will have to be implemented as part of #1781 when it gets done later.

Additionally, natural=cliff is in the earth layer, not the landuse layer. Because it wouldn't be merged anyway, I left it out. I think if we want to move that to the landuse layer (which we might if we want to merge with landuse=quarry), we probably have to add that to the v2 wishlist?

Connects to #1779.

@zerebubuth zerebubuth requested a review from nvkelso January 14, 2019 14:57
@nvkelso nvkelso mentioned this pull request Jan 14, 2019
92 tasks
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerebubuth Can you run stats on the feature count of each landuse layer kind values that are present min_zoom < 13? Just want to make sure we're catching all the basic ones, and the exceptions are true landcover (like military or park).

@nvkelso
Copy link
Member

nvkelso commented Jan 15, 2019

Additionally, natural=cliff is in the earth layer, not the landuse layer. Because it wouldn't be merged anyway, I left it out. I think if we want to move that to the landuse layer (which we might if we want to merge with landuse=quarry), we probably have to add that to the v2 wishlist?

Let's just leave cliff where it is in the earth layer (good point about SemVer and v2). I think we only bring in lines there, so it doesn't actually matter?

@nvkelso
Copy link
Member

nvkelso commented Jan 15, 2019

And so this Github PR is easier to read...

@zerebubuth responded to #1790 (comment) in #1790 (comment):

The zoom ranges in the YAML files allow residential down to zoom 4 and natural_wood / wood down to 6, and a bunch of others down to 8. Whether any are actually that large is questionable, and I'm running a query to find out - although it may take some time to run.

@zerebubuth
Copy link
Member Author

Additional follow-up in #1795.

@zerebubuth zerebubuth merged commit 4a8cb95 into master Jan 17, 2019
@zerebubuth zerebubuth deleted the zerebubuth/1779-remap-landuse-mid-zoom branch January 17, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants