Alternate viewpoints for country boundaries. #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings in the Natural Earth v5.0-pre1 data, including the new disputed areas table, and feeds it through the YAML to assign kinds and `kind:XX` variants in the same manner as `name:XX` translations. Also, fix up tests to use new tilequeue `Context` constructor.
nvkelso
reviewed
Jan 31, 2019
|
This looks good to me so far, just the one comment about min_zoom... and please add a test for the transform of say |
… to match (needed new min_zoom column).
|
I've changed the |
zerebubuth
changed the title
rmarianski
approved these changes
Feb 1, 2019
zerebubuth
added a commit
that referenced
this pull request
Feb 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alternate viewpoints about country boundaries following #1552. This means adding a
kind:XXwhere a particular country has a different opinion about thekindof a boundary from the default. This should be used in the same way asname:XXtranslations. A newkind,unrecognized, indicates that the boundary should not be shown in that country's viewpoint.Connects to #1552.