Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the generator:source tag for generator kind_detail #1865

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Use the generator:source tag for generator kind_detail #1865

merged 1 commit into from
Apr 10, 2019

Conversation

zerebubuth
Copy link
Member

Rather than generator:method. Backfill from generator:method if needed.

Connects to #1578.

@zerebubuth
Use the generator:source tag for generator kind_detail, rather than g…
67a2bbb 
…enerator:method. Backfill from generator:method if needed.
@zerebubuth zerebubuth requested a review from nvkelso April 9, 2019 17:48
nvkelso
nvkelso approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerebubuth zerebubuth merged commit 282f3aa into master Apr 10, 2019
@zerebubuth zerebubuth deleted the zerebubuth/1578-generator-kind-detail branch April 10, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkelso nvkelso nvkelso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zerebubuth @nvkelso