Treat NaN and Inf as invalid #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although these are, technically, valid floating point values, we don't really expect to see them in real input data - and they don't convey useful information about real-world features. Further, they can cause other stages of the pipeline which were written with finite numbers in mind to raise exceptions, breaking the build. This changes the behaviour of `to_float` to treat `NaN` and `Inf` as if they were not valid floating point numbers, returning `None` instead.
iandees
approved these changes
Jun 11, 2019
rmarianski
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although these are, technically, valid floating point values, we don't really expect to see them in real input data - and they don't convey useful information about real-world features. Further, they can cause other stages of the pipeline which were written with finite numbers in mind to raise exceptions, breaking the build.
This changes the behaviour of
to_floatto treatNaNandInfas if they were not valid floating point numbers, returningNoneinstead.