Chinese parser for OSM #1956
Chinese parser for OSM #1956
Conversation
| @@ -612,6 +623,42 @@ def _convert_osm_l10n_name(x): | |||
| return LangResult(code=result, priority=priority) | |||
|
|
|||
|
|
|||
| def post_process_osm_zh(properties): | |||
| """ First check whether name:zh (Simplified) and name:zht(Traditional) | |||
ok, I will remove the zh-default prop |
There was a problem hiding this comment.
For the docs checkmark, thanks for updating the TESTS.md, but please also update
https://github.com/tilezen/vector-datasource/blob/master/docs/layers.md#name-localization
With a note about name:zh (Simplified Chinese characters as used in China and Singapore) and name:zht for (Traditional Chinese characters used in Taiwan, Hong Kong, Macau) and how the data value backfilling works, and that we don't auto-translate to simplified <> traditional.
@nvkelso |
fixed |
| 'name:zh': u'旧金山', | ||
| 'name:zht': u'舊金山'}) | ||
|
|
||
| self.assert_no_matching_feature(16, 10482, 25330, 'places', {'name:zh-default': u'旧金山/三藩市/舊金山'}) |
There was a problem hiding this comment.
Nit: Please format this onto multiple lines like the other assert for legibility / convention.
#1955