Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linter on master #2036

Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix linter on master #2036

merged 1 commit into from
Dec 13, 2021

Conversation

peitili
Copy link
Contributor

@peitili peitili commented Dec 13, 2021

There are some linter violations that might be brought by

#2001
#2015

so fixing those

@peitili peitili requested review from iandees and nvkelso December 13, 2021 22:49
@peitili peitili mentioned this pull request Dec 13, 2021
Open
@iandees
Copy link
Member

iandees commented Dec 13, 2021

FWIW, I had pre-commit enabled/installed when I was working on this code and it didn't catch any of these.

@peitili
Copy link
Contributor Author

peitili commented Dec 13, 2021 •
edited
Loading

FWIW, I had pre-commit enabled/installed when I was working on this code and it didn't catch any of these.

that's because your PR branch didn't rebase some of the newer linters I believe? so I suggested something like I mentioned in here

#2021 (comment)

@peitili peitili merged commit 034e2a2 into master Dec 13, 2021
@peitili peitili deleted the fixlintermaster branch December 13, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iandees iandees iandees approved these changes

@nvkelso nvkelso Awaiting requested review from nvkelso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peitili @iandees @peitilisc