Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildings layer thining on z14 to z15 #2052

Merged
merged 22 commits into from
Feb 12, 2022
Merged

buildings layer thining on z14 to z15 #2052

merged 22 commits into from
Feb 12, 2022

Conversation

peitili
Copy link
Contributor

@peitili peitili commented Feb 3, 2022

  • Update tests
  • Update docs

@peitili peitili changed the title Peiti/thin14 buildings layer thining Feb 4, 2022
@peitili peitili changed the title buildings layer thining buildings layer thining on z14 to z15 Feb 4, 2022
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
@nvkelso
Copy link
Member

nvkelso commented Feb 4, 2022

Please also try adding:

16: vectordatasource.transform.quantize_height_round_nearest_10_meters
or
16: vectordatasource.transform.quantize_height_round_nearest_5_meters

(the 5_meters one already exists as a transform, so no need to add)

@nvkelso
Copy link
Member

nvkelso commented Feb 4, 2022

In buildings.yaml:

  - &z15_area_volume
      way_area: { min: 20 }
  - &z16_area_volume
      way_area: { min: 10 }

Which is producing quite a bit of noise in Barcelona at tile 15/16581/12239 (512px size).

Suggest doubling those to:

  - &z15_area_volume
      way_area: { min: 40 }
  - &z16_area_volume
      way_area: { min: 20 }

More extreme we could add back in volume as well:

  - &z15_area_volume
      way_area: { min: 50 }
      volume: { min: 20000 }
  - &z16_area_volume
      way_area: { min: 30 }
      volume: { min: 8000 }

queries.yaml Outdated Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
queries.yaml Outdated Show resolved Hide resolved
queries.yaml Show resolved Hide resolved
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Depends on tilezen/tilequeue#407

@peitili
Copy link
Contributor Author

peitili commented Feb 12, 2022

@nvkelso I changed back some end_zoom to 17 since we verified that works with the tilequeue fix tilezen/tilequeue#407

would you go over all the configs here for 17 and 16 again? thanks

@peitili peitili merged commit e77ae4d into master Feb 12, 2022
@peitili peitili deleted the peiti/thin14 branch February 12, 2022 02:21
@nvkelso
Copy link
Member

nvkelso commented Feb 12, 2022

Estimated impact on 512px sized tiles:

  • z13: reduction of 5%
  • z14: reduction of 10-15%
  • z15: reduction of 1 to 50% (that's right!) due to insane building detail in cities like Barcelona

tgrigsby-sc added a commit that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants