roads layer thining z14 to z15 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peitili
commented
Feb 8, 2022
•
peitili
commented
- Update tests
- Update docs
nvkelso
reviewed
Feb 9, 2022
nvkelso
reviewed
Feb 9, 2022
nvkelso
reviewed
Feb 9, 2022
nvkelso
reviewed
Feb 9, 2022
for more information, see https://pre-commit.ci
peitili
force-pushed
the
peiti/roadsthin
branch
from
b327c54
to
8a825e1
Compare
peitili
commented
Feb 12, 2022
| z, x, y = tile | ||
| self.assert_has_feature( | ||
| z, x, y, 'roads', | ||
| {'id': type(None), 'shield_text': 'A151'}) |
There was a problem hiding this comment.
@nvkelso basically I copied the implementation of _check_network_relation and the only diffrence I made here is to assert 'id': type(None) instead. Before it asserts the id == way_id
nvkelso
reviewed
Feb 12, 2022
nvkelso
reviewed
Feb 12, 2022
nvkelso
reviewed
Feb 12, 2022
nvkelso
reviewed
Feb 12, 2022
nvkelso
reviewed
Feb 12, 2022
| @@ -13,7 +13,7 @@ def test_motorway_bridge(self): | |||
| self.assert_has_feature( | |||
| 16, 10472, 25323, 'roads', | |||
| {'kind': 'highway', 'kind_detail': 'motorway', 'id': 28412298, | |||
| 'name': 'Presidio Pkwy.', 'is_bridge': True, 'sort_rank': 443}) | |||
| 'name': type(None), 'is_bridge': True, 'sort_rank': 443}) | |||
There was a problem hiding this comment.
This is because the feature is too short to fit the label, while at zoom 17 it would fit / we don't drop.
nvkelso
reviewed
Feb 12, 2022
| @@ -50,7 +50,7 @@ def test_secondary_level_0(self): | |||
| self.assert_has_feature( | |||
| 16, 16812, 24391, 'roads', | |||
There was a problem hiding this comment.
If you updated this to 17, 33624, 48782 then the name would still be there, but it's fine this way.
|
Estimated impact on 512px sized tiles:
|
nvkelso
approved these changes
Feb 12, 2022
peitili
commented
Feb 12, 2022
| @@ -114,9 +115,10 @@ def test_inbound_and_outbound_routes(self): | |||
| 16, 10477, 25327, 'roads', | |||
| {'id': 225516711, | |||
| 'bus_network': type(None), | |||
| 'bus_shield_text': '3', | |||
| 'bus_shield_text': type(None), | |||
| 'is_bus_related': True, | |||
There was a problem hiding this comment.
this is wrong, the integ test says it should be None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.