-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recast Australia suburbs to towns #2070
Conversation
for more information, see https://pre-commit.ci
bbox | ||
where st_within(way, bbox.geom)), | ||
|
||
trim_major_cities as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain that these 5 big labels are already in OSM are place=city, so we're trimming so we don't end up with duplicate place=town labels on the map.
@@ -0,0 +1,31 @@ | |||
-- Suburbs in Australia are treated more like cities, so this recasts them to place=town | |||
|
|||
with bbox as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This looks not like a box to me... maybe say bounds
instead of bbox
?
Here and elsewhere...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits but LGTM
…ds' into junderwood/australia_neighborhoods
This changes place=suburb features within an Australian polygon into place=town to allow rendering.