Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recast Australia suburbs to towns #2070

Merged
merged 6 commits into from
Apr 22, 2022

Conversation

jeffdefacto
Copy link
Contributor

This changes place=suburb features within an Australian polygon into place=town to allow rendering.

@jeffdefacto jeffdefacto requested a review from nvkelso April 22, 2022 18:43
bbox
where st_within(way, bbox.geom)),

trim_major_cities as
Copy link
Member

@nvkelso nvkelso Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain that these 5 big labels are already in OSM are place=city, so we're trimming so we don't end up with duplicate place=town labels on the map.

@@ -0,0 +1,31 @@
-- Suburbs in Australia are treated more like cities, so this recasts them to place=town

with bbox as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This looks not like a box to me... maybe say bounds instead of bbox?

Here and elsewhere...

Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but LGTM

junderwood added 2 commits April 22, 2022 12:24
@jeffdefacto jeffdefacto merged commit d644f8a into master Apr 22, 2022
@jeffdefacto jeffdefacto deleted the junderwood/australia_neighborhoods branch April 22, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants