Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to NE 5.1.2 - Add Config for new POVs #2078

Merged
merged 17 commits into from
May 17, 2022
Merged

Move to NE 5.1.2 - Add Config for new POVs #2078

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e853595
updating to newest date in assets.yaml
tgrigsby-sc Apr 28, 2022
fc1f2c6
updating assets.yaml
tgrigsby-sc Apr 29, 2022
776ff67
updating assets.yaml to pull from 5.1.0 now
tgrigsby-sc May 4, 2022
b05b25d
split lookup depending on whether it's a country (#2075)
tgrigsby-sc May 4, 2022
b810954
return fclass_iso, fclass_tlc, and label_x, label_y for OSM features …
tgrigsby-sc May 4, 2022
b51e372
adding TLC POV to NE export, YAML files and transform.py (#2081)
tgrigsby-sc May 4, 2022
e0fa3de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 4, 2022
a4b218a
updating comment
tgrigsby-sc May 5, 2022
1a8a020
updating prj for admin_0 countries assets
tgrigsby-sc May 5, 2022
3ba8648
update .gitignore
tgrigsby-sc May 6, 2022
31a5b4a
PR feedback
tgrigsby-sc May 6, 2022
761ae3c
adding tests
tgrigsby-sc May 9, 2022
2635448
updating assets file to 5.1.1, removing projection spec
tgrigsby-sc May 9, 2022
2e59334
disambiguate
tgrigsby-sc May 11, 2022
1185427
adding disadmbiguation
tgrigsby-sc May 13, 2022
24c86c9
upgrading to 5.1.2
tgrigsby-sc May 13, 2022
8fb9226
updating shapefile again
tgrigsby-sc May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion data/assets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
bucket: nextzen-tile-assets
datestamp: 20220429
datestamp: 20220505

shapefiles:

Expand Down Expand Up @@ -141,12 +141,15 @@ shapefiles:

- name: ne_10m_admin_0_countries
url: https://naciscdn.org/naturalearth/5.1.0/10m/cultural/ne_10m_admin_0_countries.zip
prj: 3857
Copy link
Member

@nvkelso nvkelso May 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files aren't web mercator (3857). Instead they need to be re-projected and clipped into web mercator from WGS84 lat/lng.

That's usually a later step in the (mostly?) automated build assets scripting. Doesn't look like that part ran in the ZIP you posted.

(Like the other NE files here, the prj: 3857 line is both not needed and in this case wrong and should be removed.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated here: 2635448


- name: ne_10m_admin_0_countries_iso
url: https://naciscdn.org/naturalearth/5.1.0/10m/cultural/ne_10m_admin_0_countries_iso.zip
prj: 3857

- name: ne_10m_admin_0_countries_tlc
url: https://naciscdn.org/naturalearth/5.1.0/10m/cultural/ne_10m_admin_0_countries_tlc.zip
prj: 3857

- name: ne_10m_admin_0_map_units
url: https://naciscdn.org/naturalearth/5.1.0/10m/cultural/ne_10m_admin_0_map_units.zip
Expand Down