Update public_transport funk #634
Conversation
|
LGTM |
| @@ -6,9 +6,9 @@ highway,public_transport,railway,route,service,tags->rail,tags->site,min_zoom,ki | |||
| *,*,*,funicular;monorail,*,*,*,${12},${route} | |||
| *,*,halt;stop;tram_stop,*,*,*,*,${13},${railway} | |||
| platform,*,*,*,*,*,*,${15},platform | |||
| *,platform,*,*,*,yes,*,${15},platform | |||
| *,platform,*,*,*,yes,*,${17},platform | |||
There was a problem hiding this comment.
Should the kind here be bus_stop?
There was a problem hiding this comment.
Nice catch, fixed in 08b3202.
|
I think the changes to POIs would make it turn something that was plain Also, tests would be good for figuring out what the effect of these would be, i.e: including one for the various different common cases. |
| *,*,*,light_rail;tram,*,*,*,*,${9},${route} | ||
| *,*,*,funicular;monorail,*,*,*,*,${12},${route} | ||
| *,*,halt;stop;tram_stop,*,*,*,*,*,${13},${railway} | ||
| platform,*,*,*,*,*,*,*,${15},platform |
There was a problem hiding this comment.
Shouldn't highway=platform also be a bus_stop at z >= 17?
|
@zerebubuth I added a few tests, do you think it looks good enough to merge now? |
|
Looking good. Let's get this on dev. |
|
I'll merge this in, we can make any adjustments afterwards if need be. |
Connects to #469
@nvkelso, @zerebubuth could you review please?