Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olga/933 building part docs #944

Merged
merged 3 commits into from
Aug 5, 2016
Merged

Olga/933 building part docs #944

merged 3 commits into from
Aug 5, 2016

Conversation

okavvada
Copy link
Contributor

@okavvada okavvada commented Aug 4, 2016

Connects to #933.

  • Update tests
  • Update data migrations
  • Update docs

@nvkelso , @rmarianski , @zerebubuth , could you review please?

@rmarianski
Copy link
Member

👍

@@ -149,9 +149,9 @@ Combination of OpenStreetMap administrative boundaries (zoom >= 8) and Natural E
* Layer name: `buildings`
* Geometry types: `point` and `polygon`

Polygons from OpenStreetMap representing building footprint, building label_placment points, building:part features, and address points. Starts at zoom 13 by including huge buildings, progressively adding all buildings at zoom 16+. Address points are available at zoom 16+, but marked with `min_zoom: 17` to suggest that they are suitable for display at zoom level 17 and higher.
Polygons from OpenStreetMap representing building footprint, building label_placment points, building_part features, and address points. Starts at zoom 13 by including huge buildings, progressively adding all buildings at zoom 16+. Address points are available at zoom 16+, but marked with `min_zoom: 17` to suggest that they are suitable for display at zoom level 17 and higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a change in this PR, but I just noticed the "label_placment points" could be spell-fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s fix the spelling now (it’s quick).

On Thu, Aug 4, 2016 at 10:30 AM, Matt Amos notifications@github.com wrote:

In docs/layers.md
#944 (comment)
:

@@ -149,9 +149,9 @@ Combination of OpenStreetMap administrative boundaries (zoom >= 8) and Natural E

  • Layer name: buildings
  • Geometry types: point and polygon

-Polygons from OpenStreetMap representing building footprint, building label_placment points, building:part features, and address points. Starts at zoom 13 by including huge buildings, progressively adding all buildings at zoom 16+. Address points are available at zoom 16+, but marked with min_zoom: 17 to suggest that they are suitable for display at zoom level 17 and higher.
+Polygons from OpenStreetMap representing building footprint, building label_placment points, building_part features, and address points. Starts at zoom 13 by including huge buildings, progressively adding all buildings at zoom 16+. Address points are available at zoom 16+, but marked with min_zoom: 17 to suggest that they are suitable for display at zoom level 17 and higher.

Not a change in this PR, but I just noticed the "label_placment points"
could be spell-fixed.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/tilezen/vector-datasource/pull/944/files/24c65b9fe8cd0f939af4ef0ac239241e79a4b200#r73566566,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO0lNwDf0cXz3sylwUJrQkxSVAAASks5qciHHgaJpZM4Jc5j8
.

@nvkelso
Copy link
Member

nvkelso commented Aug 4, 2016

👍

@okavvada okavvada force-pushed the olga/933-building-part-docs branch from a204c32 to bbdd2ee Compare August 5, 2016 00:01
@okavvada okavvada merged commit 9b95adb into master Aug 5, 2016
@okavvada okavvada deleted the olga/933-building-part-docs branch August 5, 2016 00:24
@okavvada okavvada removed the in review label Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants