Fix deprecation warning on Ruby 2.7 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilfin
reviewed
May 2, 2020
| @@ -11,8 +11,8 @@ class Logger < ::Logger | |||
|
|
|||
| attr_accessor :default_message, :exc_key | |||
|
|
|||
| def initialize(*args) | |||
| super(*args) | |||
| def initialize(*, **) | |||
There was a problem hiding this comment.
memo) The arguments are composed of optional ones and keyword ones. https://github.com/ruby/logger/blob/master/lib/logger.rb#L380
|
@haines Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Loggerconstructor takes keyword arguments, but theOugai::Loggersubclass only takes positional arguments. This relies on the now-deprecated behaviour that if the last argument to a method is a hash it can be used as keyword arguments, so it generates a warning on Ruby 2.7:This PR fixes the deprecation warning by specifying that the constructor can take both positional and keyword arguments, and passing all arguments through to the superclass constructor.