update MMM-JsonTable.js #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me fix the build errors tomorrow |
| @@ -1,5 +1,8 @@ | |||
| # MMM-JsonTable | |||
|
|
|||
| All credit to @timdows her. | |||
There was a problem hiding this comment.
Credits are good and would be appropriate for a fork. But here I don't think it should be listed.
There was a problem hiding this comment.
Sorry never ment readme for PR
| @@ -237,13 +240,95 @@ Configuration: | |||
| position: 'top_right', | |||
| header: 'HouseDB Kwh Statistics', | |||
| config: { | |||
| url: 'https://xyz/abc/get.json', | |||
|
|
|||
| url: 'https://xyz/abc/get.json', | |||
There was a problem hiding this comment.
What for is this change?
There was a problem hiding this comment.
Readme should not be pulled
| arrayName: 'deviceKwhUsages', | ||
| descriptiveRow: '<tr><td>Name</td><td>Today</td><td>ThisWeek</td><td>LastWeek</td><td>ThisMonth</td><td>LastMonth</td></tr>' | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| Getting the data under "Forbrok" | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Please add json after the backticks.
|
Sorry @timdows i never ment for the readme to be pulled 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing nested arrays