Skip to content

Commit

Permalink
missed one change
Browse files Browse the repository at this point in the history
  • Loading branch information
zliang-min committed Jul 26, 2024
1 parent bd0f19b commit a6af890
Showing 1 changed file with 15 additions and 12 deletions.
27 changes: 15 additions & 12 deletions src/Formats/NativeWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,21 @@ void NativeWriter::write(const Block & block)
/// Serialization. Dynamic, if client supports it.
SerializationPtr serialization;
/// proton: starts
/// if (client_revision >= DBMS_MIN_REVISION_WITH_CUSTOM_SERIALIZATION)
/// {
/// auto info = column.type->getSerializationInfo(*column.column);
/// serialization = column.type->getSerialization(*info);
///
/// bool has_custom = info->hasCustomSerialization();
/// writeBinary(static_cast<UInt8>(has_custom), ostr);
/// if (has_custom)
/// info->serialializeKindBinary(ostr);
/// }
/// else
/// proton: ends
/// Because our drivers does not support custom serialization, we can only check the serialization when `compatible_with_clickhouse` is `true`,
/// i.e. this writer is writing packets to clickhouse (for ClickHouse external tables).
if (compatible_with_clickhouse &&
/// proton: ends
client_revision >= DBMS_MIN_REVISION_WITH_CUSTOM_SERIALIZATION)
{
auto info = column.type->getSerializationInfo(*column.column);
serialization = column.type->getSerialization(*info);

bool has_custom = info->hasCustomSerialization();
writeBinary(static_cast<UInt8>(has_custom), ostr);
if (has_custom)
info->serialializeKindBinary(ostr);
}
else
{
serialization = column.type->getDefaultSerialization();
column.column = recursiveRemoveSparse(column.column);
Expand Down

0 comments on commit a6af890

Please sign in to comment.