Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle methods defined with bad line info #440

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Handle methods defined with bad line info #440

merged 1 commit into from
Mar 4, 2020

Conversation

timholy
Copy link
Owner

@timholy timholy commented Mar 4, 2020

Fixes #439. CC @ablaom.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #440 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage    81.9%   81.88%   -0.02%     
==========================================
  Files          12       12              
  Lines        1547     1551       +4     
==========================================
+ Hits         1267     1270       +3     
- Misses        280      281       +1
Impacted Files Coverage Δ
src/lowered.jl 88.76% <80%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ce17d...65654df. Read the comment docs.

@timholy timholy merged commit ed7d226 into master Mar 4, 2020
@timholy timholy deleted the teh/fix_439 branch March 4, 2020 13:43
@ablaom
Copy link

ablaom commented Mar 9, 2020

Any chance of a patch release?

@timholy
Copy link
Owner Author

timholy commented Mar 9, 2020

Meant to add another fix and then make a release but my attention turned elsewhere. I'll get this out now. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise and lazy loading code / type GlobalRef has no field args
2 participants