Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow CI nightly to fail so badge is green #769

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Oct 25, 2023

There are two ways of doing this, another possibility is to have a separate ci_nightly.yml, let me know if maintainers prefer that route.

@Moelf Moelf changed the title allow nightly to fail so badge is green allow CI nightly to fail so badge is green Oct 25, 2023
@timholy
Copy link
Owner

timholy commented Nov 1, 2023

The issue is that this failure is going to be on all Julia versions starting with 1.10, so making an exception for nightly soon won't help anything. We just have to fix the test failures.

@timholy timholy closed this Nov 1, 2023
@Moelf
Copy link
Contributor Author

Moelf commented Nov 1, 2023

but this would be useful for future future? I think it's a general idea to not show red CI badge for Nightly

@timholy timholy reopened this Dec 27, 2023
@timholy
Copy link
Owner

timholy commented Dec 27, 2023

Fair enough!

@timholy timholy merged commit 4703784 into timholy:master Dec 31, 2023
5 of 10 checks passed
@Moelf Moelf deleted the allow_nightly_fail branch January 1, 2024 11:55
@timholy
Copy link
Owner

timholy commented Jan 3, 2024

Hmm, the badge is still red even though only nightly is failing.

@Moelf
Copy link
Contributor Author

Moelf commented Jan 3, 2024

@timholy
Copy link
Owner

timholy commented Jan 10, 2024

If I try updating it with

[![CI](https://github.com/timholy/Revise.jl/actions/workflows/ci.yml/badge.svg)](https://github.com/timholy/Revise.jl/actions/workflows/ci.yml)

(the text supplied by the "Create Status Badge" option, it still shows red.

@Moelf
Copy link
Contributor Author

Moelf commented Jan 11, 2024

ah, we need this line https://github.com/JuliaHEP/UnROOT.jl/blob/77b75d8f8a7d5a6a2b8c408efbcac2c00817e798/.github/workflows/ci.yml#L14C1-L14C51

the allow_failure: true is not a real option, continue-on-error is, but we want to control which step is continue-on-error.

I don't know if we can just replace allow_failure with continue-on-error

timholy added a commit that referenced this pull request Jan 11, 2024
timholy added a commit that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants