Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename snoopi_deep -> snoopi_tree #190

Closed
wants to merge 1 commit into from
Closed

Conversation

timholy
Copy link
Owner

@timholy timholy commented Dec 27, 2020

I don't think this is a big win, but "deep" seems pretty nonspecific.
I personally find "tree" to be more descriptive of what you get back
from this macro.

But I'm happy to close this without merging if others are attached to "deep."

EDIT: maybe the "deep" here is in reference to deepcopy? I hadn't actually made that connection, so maybe the original is fine as is. Let's see if others chime in with thoughts on the matter.

I don't think this is a big win, but "deep" seems pretty nonspecific.
I personally find "tree" to be more descriptive of what you get back
from this macro.
@timholy
Copy link
Owner Author

timholy commented Dec 27, 2020

I don't think @Sacha0 is watching this, but a change like this should get some eyeballs on it. There have been lots of others, but renaming is pretty noticable... https://github.com/timholy/SnoopCompile.jl/pulls?q=is%3Apr+is%3Aclosed

@Sacha0
Copy link

Sacha0 commented Dec 28, 2020

👍 more descriptive! :)

@timholy
Copy link
Owner Author

timholy commented Dec 28, 2020

Sounds good. I'm in the middle of finishing off a more comprehensive version of #180; I'll resubmit this after that merges. (There will be a lot of conflicts.)

@Sacha0
Copy link

Sacha0 commented Dec 28, 2020

Cheers, please feel welcome to ping me for review and I'll do my best to work it in (though regrettably likely with relatively high latency, and after finishing off JuliaLang/www.julialang.org#1093).

Hope you have been having and continue to have a lovely holiday season! :)

@timholy
Copy link
Owner Author

timholy commented Dec 28, 2020

That version of the blog post will have to be pretty extensively rewritten. I've iterated several times between "use it in anger" and "polish the rough edges," and there have been a lot of changes; not just to the API, but how I think about tackling this. (The seeds are all there, but it is still going to be a pretty big rewrite.)

So I wouldn't yet put much time into that post. My main thought is to now split it into a series of posts; the first will have background material, and is now at JuliaLang/www.julialang.org#1111. Feel free, or not, to review it.

@timholy
Copy link
Owner Author

timholy commented Jan 5, 2021

I'm going to just stick with @snoopi_deep.

@timholy timholy closed this Jan 5, 2021
@timholy timholy deleted the teh/rename_deep_tree branch January 5, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants