Identify invalidating blockers of precompilation #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to identify the particular invalidations that block
precompilation of particular MethodInstances.
I am not 100% sure this is right. In particular, it might be too conservative; maybe one should
SnoopCompile.getrroot(hits[i])
to see the real impact? But I checked whether the root CodeInstances are there in the precompile cache, and they seem to be. So my best guess is that this is painting an accurate picture as-is. I might let this sit on master for a few days before making a release.CC @ChrisRackauckas. It seems to suggest that invalidation is not your first-order problem with SciML/ModelingToolkit.jl#1215, as you seemed to expect. But I wanted to get this tool out there in some form.