Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: complete the README #38

Merged
merged 5 commits into from
Jul 22, 2022
Merged

chore: complete the README #38

merged 5 commits into from
Jul 22, 2022

Conversation

lemeurherve
Copy link
Contributor

@lemeurherve lemeurherve commented Jul 21, 2022 •
edited
Loading

timja
timja reviewed Jul 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
timja
timja reviewed Jul 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
timja
timja reviewed Jul 21, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
timja
timja approved these changes Jul 21, 2022
View reviewed changes
Copy link
Owner

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, what do you think about including the chart installation instructions in the chart README too? (make sure you edit the template and re-generate with helm-docs or the pre-commit hook)

@lemeurherve lemeurherve requested a review from timja July 22, 2022 14:41
@timja
Copy link
Owner

timja commented Jul 22, 2022

/label chore

@timja timja merged commit afce9f0 into timja:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemeurherve @timja @lemeurherveCB