Add SelectionResult type to make type alias extraction easier #111
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timkendall/tql/CDT7QWfeYVKzxbbKie6VZkNR2aHG |
| @@ -81,3 +83,9 @@ type HasInlineFragment<T extends SelectionSet<any> | undefined> = T extends Sele | |||
| : never; | |||
|
|
|||
| type Merge<M, N> = Omit<M, keyof N> & N; | |||
|
|
|||
| export type SelectionResult<TSelection> = | |||
There was a problem hiding this comment.
Ah yeah I was planning on actually making this the default for our standard Result type. Thoughts on renaming our existing Result to InnerResult instead (so we can export this higher-level API as Result)?
There was a problem hiding this comment.
Sure, that sounds better.
I wanted to avoid a breaking change, but I can update that if you prefer exposing as Result.
There was a problem hiding this comment.
True. Let's go with this for now.
There was a problem hiding this comment.
And as always thank you for your contribution!
|
Published as @timkendall/tql@1.0.0-rc.7, @timkendall/tql@beta, @timkendall/tql-gen@1.0.0-rc.7, @timkendall/tql-gen@latest |
Resolves #109