fix: bundle Ringmaster icon missing from legacy CDN

timkurvers · Aug 31, 2024 · 84e0bc7 · 84e0bc7
1 parent 937d9a8
commit 84e0bc7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/public/images/heroes/ringmaster_icon.png b/public/images/heroes/ringmaster_icon.png
diff --git a/src/lib/resources.js b/src/lib/resources.js
@@ -29,12 +29,13 @@ const MISSING_ABILITY_RESOURCES = [
   'warpine_raider_seed_shot',
 ];
 
-const MISSING_HERO_RESOURCES = [
-  'dawnbreaker',
-  'marci',
-  'muerta',
-  'primal_beast',
-];
+const MISSING_HERO_RESOURCES = {
+  dawnbreaker: ['portrait', 'landscape', 'icon'],
+  marci: ['portrait', 'icon'],
+  muerta: ['portrait', 'icon'],
+  primal_beast: ['portrait', 'icon'],
+  ringmaster: ['icon'],
+};
 
 const KNOWN_DUMMY_UNITS = [
   'npc_dota_base_additive',
@@ -84,7 +85,7 @@ export const heroResourceFor = (refname, variant) => {
 
   // Various new heroes lack portrait and low-bandwidth images on legacy CDN so use bundled
   let base = CDN_BASE_URL;
-  if (MISSING_HERO_RESOURCES.includes(heroname)) {
+  if (MISSING_HERO_RESOURCES[heroname]?.includes(variant)) {
     base = BUNDLED_BASE_URL;
   }
   return `${base}/heroes/${heroname}${suffix}`;