Enable ESLint Job (#1190)

* Enable ESLint Job

* Use packages parameter

* Run as script

* Update lockfile

* Update PNP

* import fs

* eslint fixes

* Fixes

.eslintrc.json

@@ -1,9 +1,7 @@
 {
   "extends": [
     "plugin:react/recommended",
-    "plugin:@typescript-eslint/recommended",
-    "prettier/@typescript-eslint",
-    "plugin:prettier/recommended"
+    "plugin:@typescript-eslint/recommended"
   ],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {

.vscode/extensions.json

@@ -0,0 +1,7 @@
+{
+  "recommendations": [
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode",
+    "arcanis.vscode-zipfs"
+  ]
+}

.vscode/settings.json

@@ -1,6 +1,6 @@
 {
-  "prettier.prettierPath": ".vscode/pnpify/prettier/index.js",
-  "typescript.tsdk": ".vscode/pnpify/typescript/lib",
+  "prettier.prettierPath": ".yarn/sdks/prettier/index.js",
+  "typescript.tsdk": ".yarn/sdks/typescript/lib",
   "typescript.enablePromptUseWorkspaceTsdk": true,
-  "eslint.nodePath": ".vscode/pnpify"
+  "eslint.nodePath": ".yarn/sdks"
 }

azure-pipelines-ci.yml

@@ -38,7 +38,7 @@ stages:
   - stage: 'Lint'
     dependsOn: []
     jobs:
-      # - template: azure-ci/lint/eslint.yml@organization
+      - template: azure-ci/lint/eslint.yml@organization
       - template: azure-ci/lint/hadolint.yml@organization
       - template: azure-ci/lint/jsonlint.yml@organization
       - template: azure-ci/lint/markdownlint.yml@organization

azure-pipelines-edge.yml

@@ -41,7 +41,7 @@ stages:
   - stage: 'Lint'
     dependsOn: []
     jobs:
-      # - template: azure-ci/lint/eslint.yml@organization
+      - template: azure-ci/lint/eslint.yml@organization
       - template: azure-ci/lint/hadolint.yml@organization
       - template: azure-ci/lint/jsonlint.yml@organization
       - template: azure-ci/lint/markdownlint.yml@organization

azure-pipelines-release.yml

@@ -41,7 +41,7 @@ stages:
   - stage: 'Lint'
     dependsOn: []
     jobs:
-      # - template: azure-ci/lint/eslint.yml@organization
+      - template: azure-ci/lint/eslint.yml@organization
       - template: azure-ci/lint/hadolint.yml@organization
       - template: azure-ci/lint/jsonlint.yml@organization
       - template: azure-ci/lint/markdownlint.yml@organization

backend/src/authentication.ts

@@ -7,7 +7,7 @@ import { Application } from './declarations';
 
 declare module './declarations' {
   interface ServiceTypes {
-    authentication: AuthenticationService & ServiceAddons<any>;
+    authentication: AuthenticationService & ServiceAddons<unknown>;
   }
 }
 

backend/src/channels.ts

@@ -7,12 +7,13 @@ export default function (app: Application): void {
     return;
   }
 
-  app.on('connection', (connection: any): void => {
+  app.on('connection', (connection: unknown): void => {
     // On a new real-time connection, add it to the anonymous channel
     app.channel('anonymous').join(connection);
   });
 
-  app.on('login', (authResult: any, { connection }: any) => {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  app.on('login', (_authResult: any, { connection }: any) => {
     // connection can be undefined if there is no
     // real-time connection, e.g. when logging in via REST
     if (connection) {

backend/src/hooks/populate-user.ts

@@ -2,6 +2,12 @@
 // For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
 import { Hook, HookContext } from '@feathersjs/feathers';
 
+interface Configuration {
+  user: string;
+  userId: string;
+}
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default (_options = {}): Hook => {
   return async (context: HookContext): Promise<HookContext> => {
     // Get `app`, `method`, `params` and `result` from the hook context
@@ -18,14 +24,14 @@ export default (_options = {}): Hook => {
     // Asynchronously get user object from each message's `userId`
     // and add it to the message
     await Promise.all(
-      config.map(async (config: any) => {
+      config.map(async (config: Configuration) => {
         // Also pass the original `params` to the service call
         // so that it has the same information available (e.g. who is requesting it)
         config.user = await app.service('users').get(config.userId, params);
       })
     );
 
-    config = config.filter((config: any) => config.userId === userId);
+    config = config.filter((config: Configuration) => config.userId === userId);
 
     if (method === 'find') result.data = config;
     else result = result.userId === userId ? result : null;

backend/src/hooks/process-config-update.ts

@@ -2,6 +2,7 @@
 // For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
 import { Hook, HookContext } from '@feathersjs/feathers';
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default (_options = {}): Hook => {
   return async (context: HookContext) => {
     const { data } = context;

backend/src/hooks/process-config.ts

@@ -1,7 +1,9 @@
 // Use this hook to manipulate incoming or outgoing data.
 // For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
 import { Hook, HookContext } from '@feathersjs/feathers';
+import fs from 'fs';
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default (_options = {}): Hook => {
   return async (context: HookContext): Promise<HookContext> => {
     const { data } = context;
@@ -10,7 +12,7 @@ export default (_options = {}): Hook => {
 
     if (createNew) {
       config = JSON.parse(
-        require('fs').readFileSync('config/config.default.json')
+        String(fs.readFileSync('config/config.default.json'))
       );
       // Throw an error if there isn't any default config
       if (!config)

backend/src/hooks/process-controller.ts

@@ -2,6 +2,7 @@
 // For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
 import { Hook, HookContext } from '@feathersjs/feathers';
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export default (_options = {}): Hook => {
   return async (context: HookContext): Promise<HookContext> => {
     const { app, data, params } = context;

backend/src/middleware/index.ts

@@ -1,4 +1,5 @@
 import { Application } from '../declarations';
 // Don't remove this comment. It's needed to format import lines nicely.
 
-export default function (app: Application) {}
+// eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-empty-function
+export default function (_app: Application) {}

backend/src/models/config.model.ts

@@ -2,6 +2,7 @@ import NeDB from 'nedb';
 import path from 'path';
 import { Application } from '../declarations';
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export default function (app: Application) {
   const dbPath = app.get('nedb');
   const Model = new NeDB({

backend/src/models/users.model.ts

@@ -2,6 +2,7 @@ import NeDB from 'nedb';
 import path from 'path';
 import { Application } from '../declarations';
 
+// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export default function (app: Application) {
   const dbPath = app.get('nedb');
   const Model = new NeDB({

backend/src/services/config/config.class.ts

@@ -2,6 +2,7 @@ import { Service, NedbServiceOptions } from 'feathers-nedb';
 import { Application } from '../../declarations';
 
 export class Config extends Service {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   constructor(options: Partial<NedbServiceOptions>, _app: Application) {
     super(options);
   }

backend/src/services/config/config.service.ts

@@ -8,11 +8,11 @@ import hooks from './config.hooks';
 // Add this service to the service type index
 declare module '../../declarations' {
   interface ServiceTypes {
-    config: Config & ServiceAddons<any>;
+    config: Config & ServiceAddons<unknown>;
   }
 }
 
-export default function (app: Application) {
+export default function (app: Application): void {
   const Model = createModel(app);
   const paginate = app.get('paginate');
 

backend/src/services/controller/controller.class.ts

@@ -22,10 +22,12 @@ export class Controller implements ServiceMethods<Data> {
     this.app = app;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async find(_params?: Params): Promise<Data[] | Paginated<Data>> {
     return [];
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async get(id: Id, _params?: Params): Promise<Data> {
     return {
       id,
@@ -41,14 +43,17 @@ export class Controller implements ServiceMethods<Data> {
     return data;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async update(_id: NullableId, data: Data, _params?: Params): Promise<Data> {
     return data;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async patch(_id: NullableId, data: Data, _params?: Params): Promise<Data> {
     return data;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async remove(id: NullableId, _params?: Params): Promise<Data> {
     return { id };
   }

backend/src/services/controller/controller.service.ts

@@ -7,7 +7,7 @@ import hooks from './controller.hooks';
 // Add this service to the service type index
 declare module '../../declarations' {
   interface ServiceTypes {
-    controller: Controller & ServiceAddons<any>;
+    controller: Controller & ServiceAddons<unknown>;
   }
 }
 

backend/src/services/users/users.service.ts

@@ -8,7 +8,7 @@ import hooks from './users.hooks';
 // Add this service to the service type index
 declare module '../../declarations' {
   interface ServiceTypes {
-    users: Users & ServiceAddons<any>;
+    users: Users & ServiceAddons<unknown>;
   }
 }
 

frontend/package.json

@@ -43,8 +43,7 @@
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "CI=true react-scripts test --forceExit --detectOpenHandles --coverage --coverageDirectory=output/coverage/jest --reporters=default --reporters=jest-junit",
-    "eject": "react-scripts eject",
-    "eslint": "eslint -c .eslintrc.json --color src"
+    "eject": "react-scripts eject"
   },
   "browserslist": {
     "production": [
@@ -81,13 +80,7 @@
     "@types/socket.io": "2.1.8",
     "@types/socket.io-client": "1.4.33",
     "@types/superagent": "4.1.7",
-    "@typescript-eslint/eslint-plugin": "3.2.0",
-    "@typescript-eslint/parser": "3.2.0",
     "@yarnpkg/pnpify": "2.0.0-rc.25",
-    "eslint": "7.2.0",
-    "eslint-config-prettier": "6.11.0",
-    "eslint-plugin-prettier": "3.1.4",
-    "eslint-plugin-react": "7.20.0",
     "jest-junit": "10.0.0",
     "prettier": "2.0.5",
     "typescript": "3.9.5"

frontend/src/Components/Configuration/EditCard/Base.tsx

@@ -50,7 +50,7 @@ export interface BaseProps {
   ) => (event: React.ChangeEvent<HTMLInputElement>) => void;
   handleSwitchChange?: (
     name: string
-  ) => (_event: React.ChangeEvent<{}>, checked: boolean) => void;
+  ) => (_event: React.ChangeEvent<unknown>, checked: boolean) => void;
   handleSelectChange?: (
     event: React.ChangeEvent<{ name?: string; value: unknown }>
   ) => void;

frontend/src/Components/Configuration/EditCard/EditCard.tsx

@@ -66,7 +66,7 @@ function EditCard(props: EditCardProps): ReactElement {
   };
 
   const handleSwitchChange = (name: string) => (
-    _event: React.ChangeEvent<{}>,
+    _event: React.ChangeEvent<unknown>,
     checked: boolean
   ): void => {
     setCard({ ...card, [name]: checked });

frontend/src/Components/Configuration/EditCard/News.tsx

@@ -32,7 +32,7 @@ function News(props: BaseProps): ReactElement {
   const [error, setError] = useState<string>();
 
   function handleChange(
-    _event: React.ChangeEvent<{}>,
+    _event: React.ChangeEvent<unknown>,
     newValue: Option | null
   ): void {
     setSource(newValue);