Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Console Broken #57

Closed
timolson opened this issue Aug 5, 2014 · 3 comments
Closed

Windows Console Broken #57

timolson opened this issue Aug 5, 2014 · 3 comments

Comments

@timolson
Copy link
Owner

timolson commented Aug 5, 2014

Coin Trader uses the JLine library to work with the console, which requires a DLL to be installed in Windows. Users can download the DLL from the JLine site but we should try to bundle the DLL as a resource if we can.

@jule64
Copy link
Contributor

jule64 commented Aug 6, 2014

I have set the jline.WindowsTerminal.directConsole system property to false as suggested in this post and that seems to have done the trick.
Not sure if there are any loss of functionality from doing that, nor if the "noise" being printed on the console output is normal (see screenshot, console input in red)
image

@timolson
Copy link
Owner Author

timolson commented Aug 6, 2014

I see the interleaving of messages on stdout also on OS X.
Would you please put your fix into cointrader-default.properties and issue a PR?

@jule64
Copy link
Contributor

jule64 commented Aug 6, 2014

Absolutely, will send PR in the morning, thank you

-----Original Message-----
From: Tim Olson notifications@github.com
Date: Wed, 06 Aug 2014 11:31:34
To: timolson/cointradercointrader@noreply.github.com
Reply-To: timolson/cointrader reply@reply.github.com
Cc: Julien Monnierjule64@gmail.com
Subject: Re: [cointrader] Windows Console Broken (#57)

I see the interleaving of messages on stdout also on OS X.
Would you please put your fix into cointrader-default.properties and issue a PR?


Reply to this email directly or view it on GitHub:
#57 (comment)

jule64 added a commit to jule64/cointrader that referenced this issue Aug 7, 2014
Allows inputs to be read on the Windows console

Closes-Bug: timolson#57
@douggie douggie closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants