-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use structs as a container for Action inputs #17
Conversation
This reverts commit dd7d994.
// validateActionInputs validates input combinations that cannot be checked at the action-level. | ||
// In particular, ensures that the destination is valid and any other inputs required for that destination are present. | ||
func validateActionInputs() error { | ||
func validateActionInputs() (ActionInputs, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function validateActionInputs
has 67 lines of code (exceeds 50 allowed). Consider refactoring.
// validateActionInputs validates input combinations that cannot be checked at the action-level. | ||
// In particular, ensures that the destination is valid and any other inputs required for that destination are present. | ||
func validateActionInputs() error { | ||
func validateActionInputs() (ActionInputs, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function validateActionInputs
has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Code Climate has analyzed commit 54111c9 and detected 0 issues on this pull request. View more on Code Climate. |
No description provided.