fix: crash caused by racing condition in context access

timschneeb · Feb 8, 2023 · b9e0f09 · b9e0f09
1 parent 628bf83
commit b9e0f09
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/app/src/main/java/me/timschneeberger/rootlessjamesdsp/fragment/PreferenceGroupFragment.kt b/app/src/main/java/me/timschneeberger/rootlessjamesdsp/fragment/PreferenceGroupFragment.kt
@@ -83,10 +83,18 @@ class PreferenceGroupFragment : PreferenceFragmentCompat() {
                         liveprogEdit?.isEnabled = filePresent
 
                         liveprogParams?.isEnabled = count > 0
-                        liveprogParams?.summary = if(count > 0)
-                            resources.getQuantityString(R.plurals.custom_parameters, count, count)
-                        else
-                            getString(R.string.liveprog_additional_params_not_supported)
+
+                        try {
+                            liveprogParams?.summary = if (count > 0)
+                                resources.getQuantityString(R.plurals.custom_parameters, count, count)
+                            else
+                                getString(R.string.liveprog_additional_params_not_supported)
+                        }
+                        catch(ex: IllegalStateException) {
+                            /* Because this lambda is executed async, it is possible that it is called
+                               while the fragment is destroyed, leading to accessing a detached context */
+                            Timber.d(ex)
+                        }
                     }
 
                     if (recyclerView == null)