Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor structure and API #12

Merged
merged 31 commits into from
Dec 23, 2018
Merged

Refactor structure and API #12

merged 31 commits into from
Dec 23, 2018

Conversation

timsueberkrueb
Copy link
Owner

See #9.

@timsueberkrueb
Initial work on refactoring structure and API
2bdc6f6 
* Nonterminal struct is now generated internally
* Start rule is now generated internally
* Reduce the number of required attributes
* Rename LALR{Parser, Lexer} to Parser, Lexer
@timsueberkrueb timsueberkrueb changed the title WIP: Refactore structure and API WIP: Refactor structure and API Dec 15, 2018
@timsueberkrueb
Fix accept action creation
7aa7038
@timsueberkrueb
Add test for multiple start rules
1d88244
@timsueberkrueb
Run cargo fmt
870d6c0 
Not quite happy with this one, but I'm fine sacrificing that for
consistency in this case.
@timsueberkrueb
Document the YALR trait
d9fee30
@timsueberkrueb
Block merge
1172176 
Don't know what's going on here, yet, but this is a blocker
@timsueberkrueb
Generate statically sized arrays
cd6cc44 
Make generated code independent from ParseTable.
@timsueberkrueb
Drop quote support from core
7d02b36 
Now that codegen doesn't rely on converting core types to tokens
anymore, we can safely drop this.
@timsueberkrueb
Don't panic!()
b468e5b 
Return results instead of using panic!() in codegen's parse mod
@timsueberkrueb
Remove FIXME note from codegen
e2667b9
@timsueberkrueb
Add Lookahead column header for graphviz output
65ebb0f
@timsueberkrueb
Move pub traits and error types from yalr_core to yalr
095e6ad 
This decouples yalr and therefore parsers generated using the
procedural macro from yalr_core.
@timsueberkrueb
Document lalr attribute
0883dcd
@timsueberkrueb
Run rustfmt
f4196f4
@timsueberkrueb
Document rule attribute
1728980
@timsueberkrueb timsueberkrueb mentioned this pull request Dec 22, 2018
Closed
@timsueberkrueb
Copy link
Owner Author

timsueberkrueb commented Dec 22, 2018 •
edited
Loading

TODOs for this one:

  • remove lowercase requirement for terminals in rules (e.g. terminals in rules being lowercase vs. uppercase enum variants is too confusing)
  • Consider making terminal_type and start_symbol parameters of lalr

Upstream:

@timsueberkrueb timsueberkrueb changed the title WIP: Refactor structure and API Refactor structure and API Dec 23, 2018
@timsueberkrueb
Fix reachable unreachable code
6665c1c 
It is possible that not all possible terminals are handled here because
codegen only knows about the terminals that are part of the rules.
Therefore, we need to behave as if we have encountered unexpected input
in this case.
@timsueberkrueb
Return concrete ParseError instead of a trait object
3b6be91
@timsueberkrueb
Copy link
Owner Author

Don't merge yet, test case is coming.

@DanielBicek DanielBicek merged commit 2f9dc2f into develop Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBicek DanielBicek DanielBicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timsueberkrueb @DanielBicek