Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update VirtualBox settings to match current built-in OS X template #45

Merged
merged 2 commits into from
Nov 9, 2015
Merged

update VirtualBox settings to match current built-in OS X template #45

merged 2 commits into from
Nov 9, 2015

Conversation

mattieb
Copy link
Contributor

@mattieb mattieb commented Nov 7, 2015

Did this on the way to fixing #43. It didn't fix the issue, but I think it's worth tracking VirtualBox's default OS X template closely.

Of note, I removed the cpuidset that we used to need for Haswell support (cf. #13 (comment)) We clearly don't need it anymore. 👍🏻

@timsutton
Copy link
Owner

I was curious to test this myself and keep hitting a VBox error. I'm assuming this is a typical VBox stability bug, and I've rebooted a couple times and re-installed the VBox installer pkg:

==> virtualbox-iso: Executing custom VBoxManage commands...
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --audiocontroller hda
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --boot1 dvd
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --boot2 disk
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --chipset ich9
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --firmware efi
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --hpet on
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --keyboard usb
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --memory 2048
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --mouse usbtablet
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --usbehci on
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --vram 16
    virtualbox-iso: Executing: storagectl packer-virtualbox-iso-1447081357 --name IDE Controller --remove
==> virtualbox-iso: Starting the virtual machine...
==> virtualbox-iso: Error starting VM: VBoxManage error:
==> virtualbox-iso: Unregistering and deleting virtual machine...
==> virtualbox-iso: Deleting output directory...
Build 'virtualbox-iso' errored: Error starting VM: VBoxManage error:

Which version of VBox are you running? I'm running 5.0.8 on the latest 10.11.2 seed (15C31f).

@rickard-von-essen
Copy link

@timsutton can you run with PACKER_LOG=1 and gist the log.
On Nov 9, 2015 4:05 PM, "Timothy Sutton" notifications@github.com wrote:

I was curious to test this myself and keep hitting a VBox error. I'm
assuming this is a typical VBox stability bug, and I've rebooted a couple
times and re-installed the VBox installer pkg:

==> virtualbox-iso: Executing custom VBoxManage commands...
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --audiocontroller hda
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --boot1 dvd
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --boot2 disk
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --chipset ich9
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --firmware efi
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --hpet on
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --keyboard usb
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --memory 2048
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --mouse usbtablet
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --usbehci on
virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447081357 --vram 16
virtualbox-iso: Executing: storagectl packer-virtualbox-iso-1447081357 --name IDE Controller --remove
==> virtualbox-iso: Starting the virtual machine...
==> virtualbox-iso: Error starting VM: VBoxManage error:
==> virtualbox-iso: Unregistering and deleting virtual machine...
==> virtualbox-iso: Deleting output directory...
Build 'virtualbox-iso' errored: Error starting VM: VBoxManage error:

Which version of VBox are you running? I'm running 5.0.8 on the latest
10.11.2 seed (15C31f).


Reply to this email directly or view it on GitHub
#45 (comment)
.

@mattieb
Copy link
Contributor Author

mattieb commented Nov 9, 2015

@timsutton: 5.0.8 on 10.11.1. If @rickard-von-essen's suggestion will tell me what the VBoxManage error was, I'm all for it, because that would help me… it might be the storagectl, which we could probably remove if needed.

@timsutton
Copy link
Owner

I just reset my working tree to prior to this commit and it worked - it does indeed seem to be the storagectl flag, despite VBoxManager not giving us a hand with any error output (that I could find):

2015/11/09 10:27:22 ui: ==> virtualbox-iso: Executing custom VBoxManage commands...
==> virtualbox-iso: Executing custom VBoxManage commands...
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --audiocontroller hda
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--audiocontroller", "hda"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --audiocontroller hda
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --boot1 dvd
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--boot1", "dvd"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --boot1 dvd
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --boot2 disk
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--boot2", "disk"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --boot2 disk
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --chipset ich9
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--chipset", "ich9"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --chipset ich9
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --firmware efi
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--firmware", "efi"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --firmware efi
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --hpet on
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--hpet", "on"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --hpet on
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --keyboard usb
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--keyboard", "usb"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --keyboard usb
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --memory 2048
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--memory", "2048"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --memory 2048
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --mouse usbtablet
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--mouse", "usbtablet"}
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --mouse usbtablet
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --usbehci on
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --usbehci on
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--usbehci", "on"}
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stdout:
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 stderr:
2015/11/09 10:27:22 ui:     virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --vram 16
    virtualbox-iso: Executing: modifyvm packer-virtualbox-iso-1447082830 --vram 16
2015/11/09 10:27:22 packer-builder-virtualbox-iso: 2015/11/09 10:27:22 Executing VBoxManage: []string{"modifyvm", "packer-virtualbox-iso-1447082830", "--vram", "16"}
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 stdout:
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 stderr:
2015/11/09 10:27:23 ui:     virtualbox-iso: Executing: storagectl packer-virtualbox-iso-1447082830 --name IDE Controller --remove
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 Executing VBoxManage: []string{"storagectl", "packer-virtualbox-iso-1447082830", "--name", "IDE Controller", "--remove"}
    virtualbox-iso: Executing: storagectl packer-virtualbox-iso-1447082830 --name IDE Controller --remove
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 stdout:
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 stderr:
2015/11/09 10:27:23 ui: ==> virtualbox-iso: Starting the virtual machine...
==> virtualbox-iso: Starting the virtual machine...
2015/11/09 10:27:23 packer-builder-virtualbox-iso: 2015/11/09 10:27:23 Executing VBoxManage: []string{"startvm", "packer-virtualbox-iso-1447082830", "--type", "gui"}
2015/11/09 10:27:25 packer-builder-virtualbox-iso: 2015/11/09 10:27:25 stdout: Waiting for VM "packer-virtualbox-iso-1447082830" to power on...
2015/11/09 10:27:25 packer-builder-virtualbox-iso: VM "packer-virtualbox-iso-1447082830" has been successfully started.
2015/11/09 10:27:25 packer-builder-virtualbox-iso: 2015/11/09 10:27:25 stderr:
2015/11/09 10:27:25 ui error: ==> virtualbox-iso: Error starting VM: VBoxManage error:
==> virtualbox-iso: Error starting VM: VBoxManage error:
2015/11/09 10:27:25 packer-builder-virtualbox-iso: 2015/11/09 10:27:25 Executing VBoxManage: []string{"storageattach", "packer-virtualbox-iso-1447082830", "--storagectl", "SATA Controller", "--port", "1", "--device", "0", "--medium", "none"}
2015/11/09 10:27:25 packer-builder-virtualbox-iso: 2015/11/09 10:27:25 stdout:
2015/11/09 10:27:25 packer-builder-virtualbox-iso: 2015/11/09 10:27:25 stderr:

@mattieb
Copy link
Contributor Author

mattieb commented Nov 9, 2015

Hm, it looks like it's not the storagectl (which removes the useless IDE controller), but rather the storageattach for the SATA controller that's erroring (which is rather necessary!)

I can look at this more later, but if removing the storagectl line works, we should be fine. There'll just be a vestigial unused IDE controller like there always was before this commit.

["modifyvm", "{{.Name}}", "--firmware", "efi"],
["modifyvm", "{{.Name}}", "--hpet", "on"],
["modifyvm", "{{.Name}}", "--keyboard", "usb"],
["modifyvm", "{{.Name}}", "--memory", "2048"],
["modifyvm", "{{.Name}}", "--mouse", "usbtablet"],
["modifyvm", "{{.Name}}", "--vram", "9"]
["modifyvm", "{{.Name}}", "--usbehci", "on"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This --usbehci option seems to be the one that causes the storageattach error I just mentioned. I can set all other values in this diff and it boots, but I get the VBoxManage error with --usbehci on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, I just had a thought—have you installed the VirtualBox extension pack?

I bet it’s failing because the EHCI components are separately licensed and only available in the extension pack.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! That was totally it.

@timsutton
Copy link
Owner

Great. Merging!

timsutton added a commit that referenced this pull request Nov 9, 2015
update VirtualBox settings to match current built-in OS X template
@timsutton timsutton merged commit 36e6394 into timsutton:master Nov 9, 2015
@mattieb
Copy link
Contributor Author

mattieb commented Nov 9, 2015 via email

@timsutton
Copy link
Owner

Yes, I think so. I'm glad both this and VBox itself are in homebrew-cask - might be worth mentioning that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants