This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Simplified implementation of canUpdate. Fixed canUpdate flagging up when the local version is greater than the store version in development contexts.
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up when the local version is greater than the store version in development contexts.
timtraversy
reviewed
Dec 19, 2021
| // Each consecutive field in the version notation is less significant than the previous one, | ||
| // therefore only one comparison needs to yield `true` for it to be determined that the store | ||
| // version is greater than the local version. | ||
| for (var i = 0; i < store.length; i++) { |
There was a problem hiding this comment.
This is still a little fragile - sometimes the store and local versions are the same length but not always.
There was a problem hiding this comment.
This entire implementation is pretty naive still, because the semver 2.0 specification specifies that there can also be a build and early release version rc, while this implementation doesn't really take that into account. This pull request is not to serve to implement the whole scope of the specification, but rather improve the previous implementation.
|
I should write some tests, because version comparison can be complicated. Lots of edge cases. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.