Merge pull request mozilla#17388 from calixteman/no_double_color_picker

[Editor] Avoid to have a color picker for highlighting twice in the main toolbar
timvandermeij · Dec 6, 2023 · f54cfe0 · f54cfe0
2 parents a692f86 + cb9c855
commit f54cfe0
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/web/toolbar.js b/web/toolbar.js
@@ -121,12 +121,17 @@ class Toolbar {
     this.#bindListeners(options);
 
     if (options.editorHighlightColorPicker) {
-      this.eventBus._on("annotationeditoruimanager", ({ uiManager }) => {
-        this.#setAnnotationEditorUIManager(
-          uiManager,
-          options.editorHighlightColorPicker
-        );
-      });
+      this.eventBus._on(
+        "annotationeditoruimanager",
+        ({ uiManager }) => {
+          this.#setAnnotationEditorUIManager(
+            uiManager,
+            options.editorHighlightColorPicker
+          );
+        },
+        // Once the color picker has been added, we don't want to add it again.
+        { once: true }
+      );
     }
 
     this.reset();