Skip to content

Commit

Permalink
test(docker): remove outdated logging-related step (kedro-org#207)
Browse files Browse the repository at this point in the history
* fixkedro- docker e2e test

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* fix: add timeout to request to satisfy bandit lint

---------

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Tom Kurian <tom_kurian@mckinsey.com>
  • Loading branch information
2 people authored and kuriantom369 committed May 30, 2023
1 parent b94f211 commit 9381816
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
1 change: 0 additions & 1 deletion kedro-docker/features/docker.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Docker commands in new projects
Background:
Given I have prepared a config file
And I run a non-interactive kedro new using pandas-iris starter
And I have fixed logs write permission
And I have installed the project dependencies
And I have removed old docker image of test project

Expand Down
1 change: 0 additions & 1 deletion kedro-docker/features/docker_with_spark.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Feature: Docker commands in new Spark projects
Background:
Given I have prepared a config file
And I run a non-interactive kedro new using pyspark-iris starter
And I have fixed logs write permission
And I have installed the project dependencies
And I have removed old docker image of test project

Expand Down
15 changes: 0 additions & 15 deletions kedro-docker/features/steps/cli_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,21 +126,6 @@ def create_configuration_file(context):
yaml.dump(config, config_file, default_flow_style=False)


@given("I have fixed logs write permission")
def modify_write_permission(context):
"""
Kedro-docker mounts some subdirectories the current directory (like logs, notebooks etc)
into the Docker container.
If you run kedro commands with different users,
they might create files and directories not writable by each other.
So we are fixing the permissions here.
"""
(context.root_project_dir / "logs").chmod(0o777)
journal_dir = context.root_project_dir / "logs" / "journals"
journal_dir.mkdir(parents=True, exist_ok=True)
journal_dir.chmod(0o777)


@given("I run a non-interactive kedro new using {starter_name} starter")
def create_project_from_config_file(context, starter_name):
"""Behave step to run kedro new
Expand Down

0 comments on commit 9381816

Please sign in to comment.