Skip to content

[BUG] Teach DifferencingTransform to inverse_transform with NaNs #1136

Closed
1 task done
Mr-Geekman opened this issue Feb 27, 2023 · 1 comment
Closed
1 task done

[BUG] Teach DifferencingTransform to inverse_transform with NaNs #1136

Mr-Geekman opened this issue Feb 27, 2023 · 1 comment
Assignees
@Mr-Geekman
Labels
bug Something isn't working
Milestone
Inference 2.1

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Feb 27, 2023 •
edited
Loading

🐛 Bug Report

All our transforms can make inverse_transform on target after make_future except for DifferencingTransform. They just do nothing in this case and don't fail. We want also to not fail in this case.

Expected behavior

Pass test:

Fix tests on DifferencingTransform.

How To Reproduce

Run test_inverse_transform_future_subset_difference_fail (waiting for #1127).

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Feb 27, 2023
@Mr-Geekman Mr-Geekman added this to the Inference 2.1 milestone Feb 27, 2023
@Mr-Geekman Mr-Geekman self-assigned this Mar 6, 2023
@Mr-Geekman Mr-Geekman mentioned this issue Mar 6, 2023
Merged
4 tasks
@Mr-Geekman
Copy link
Contributor Author

Closed by #1155

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mr-Geekman Mr-Geekman

Labels
bug Something isn't working
Projects
etna board
Status: Done
Milestone
Inference 2.1
Development

No branches or pull requests
1 participant
@Mr-Geekman