Skip to content

Teach DifferencingTransform to inverse_transform with NaNs #1155

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Mar 6, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1136.

Closing issues

Closes #1136.

@Mr-Geekman Mr-Geekman self-assigned this Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (inference-v2.1@156eb49). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##             inference-v2.1    #1155   +/-   ##
=================================================
  Coverage                  ?   86.89%           
=================================================
  Files                     ?      164           
  Lines                     ?     9007           
  Branches                  ?        0           
=================================================
  Hits                      ?     7827           
  Misses                    ?     1180           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request March 6, 2023 13:17 Inactive
transformed.loc[start_idx:, pd.IndexSlice[current_segment, self.in_column]] = to_transform.loc[
start_idx:
].diff(periods=self.period)
transformed.loc[:, pd.IndexSlice[current_segment, self.in_column]] = to_transform.diff(periods=self.period)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be be should rework the current test to check the new behaviour, I mean run tests in fixtures with NaNs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tests do you mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current tests for DifferencingTransform (test_differencing_transform) have a fixture with NaNs at the beginning. And tests check that everything is working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about nans in the middle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add more tests in test_differencing_transform or tests in test_inference are enough?
Ok, I'll look at it.

@github-actions github-actions bot temporarily deployed to pull request March 7, 2023 11:12 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants