Skip to content

Change default final_model in StackingEnsemble #846

Closed
alex-hse-repository opened this issue Aug 11, 2022 · 3 comments
Closed

Change default final_model in StackingEnsemble #846

alex-hse-repository opened this issue Aug 11, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alex-hse-repository
Copy link
Collaborator

🚀 Feature Request

Experiments show that linear regression with positive coefficients shows better results comparing with no restrictions to the coefficients. So it is better to change the default final_model in StackingEnsemble to LinearRegression(positive=True)

Proposal

Change the default value to LinearRegression(positive=True) in the constructor of StackingEnsemble here:

self.final_model = LinearRegression() if final_model is None else final_model

Test cases

No response

Additional context

No response

@alex-hse-repository alex-hse-repository added enhancement New feature or request good first issue Good for newcomers labels Aug 11, 2022
@looopka
Copy link
Contributor

looopka commented Jan 27, 2023

let me take this issue?

@alex-hse-repository
Copy link
Collaborator Author

@looopka You can take any "Good first issue" you like)

@ostreech1997
Copy link
Collaborator

Closed by #1238

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants