-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## inference-v2 #1007 +/- ##
================================================
- Coverage 85.79% 85.76% -0.04%
================================================
Files 162 163 +1
Lines 8603 8666 +63
================================================
+ Hits 7381 7432 +51
- Misses 1222 1234 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🚀 Deployed on https://deploy-preview-1007--etna-docs.netlify.app |
martins0n
suggested changes
Nov 21, 2022
etna/core/mixins.py
Outdated
"etna_version": get_etna_version(), | ||
"class": inspect.getmodule(self).__name__, # type: ignore | ||
} | ||
metadata_str = json.dumps(metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add key sort and indent param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
martins0n
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look at #1002.
Closing issues
Closes #1002.