Skip to content

Add SaveMixin #1007

Merged
merged 14 commits into from
Nov 22, 2022
Merged

Add SaveMixin #1007

merged 14 commits into from
Nov 22, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Nov 18, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look at #1002.

Closing issues

Closes #1002.

@Mr-Geekman Mr-Geekman changed the title Issue 1002 Add SaveMixin Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #1007 (d0b585f) into inference-v2 (8264118) will decrease coverage by 0.03%.
The diff coverage is 96.96%.

@@               Coverage Diff                @@
##           inference-v2    #1007      +/-   ##
================================================
- Coverage         85.79%   85.76%   -0.04%     
================================================
  Files               162      163       +1     
  Lines              8603     8666      +63     
================================================
+ Hits               7381     7432      +51     
- Misses             1222     1234      +12     
Impacted Files Coverage Δ
etna/models/catboost.py 100.00% <ø> (ø)
etna/models/nn/mlp.py 100.00% <ø> (ø)
etna/models/nn/rnn.py 100.00% <ø> (ø)
etna/models/prophet.py 98.86% <ø> (ø)
etna/transforms/outliers/point_outliers.py 100.00% <ø> (ø)
etna/core/saving.py 83.33% <83.33%> (ø)
etna/core/__init__.py 100.00% <100.00%> (ø)
etna/core/mixins.py 98.30% <100.00%> (+1.08%) ⬆️
etna/models/base.py 86.59% <100.00%> (+0.15%) ⬆️
etna/transforms/base.py 96.22% <100.00%> (+0.07%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 18, 2022

@github-actions github-actions bot temporarily deployed to pull request November 18, 2022 15:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 18, 2022 16:06 Inactive
@martins0n martins0n self-requested a review November 21, 2022 07:45
@martins0n martins0n added this to the Inference 2.0 milestone Nov 21, 2022
@github-actions github-actions bot temporarily deployed to pull request November 21, 2022 09:02 Inactive
"etna_version": get_etna_version(),
"class": inspect.getmodule(self).__name__, # type: ignore
}
metadata_str = json.dumps(metadata)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add key sort and indent param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

etna/transforms/decomposition/stl.py Outdated Show resolved Hide resolved
tests/test_core/test_mixins.py Show resolved Hide resolved
tests/test_models/nn/test_tft.py Outdated Show resolved Hide resolved
tests/test_models/nn/test_mlp.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 21, 2022 09:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 21, 2022 09:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 21, 2022 10:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 21, 2022 15:17 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mr-Geekman Mr-Geekman merged commit 40efb0c into inference-v2 Nov 22, 2022
@Mr-Geekman Mr-Geekman deleted the issue-1002 branch November 22, 2022 07:12
@Mr-Geekman Mr-Geekman mentioned this pull request Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants